Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix of saving "clone_field" fields #18660

Merged

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#18160

Description

After the Config model's refactoring, which came with released version 2.2.6, there was an error in storing the fileds which were created using "clone_field" feature. When the values were stored, the path was wrong and the values were stored under the wrong key.

E.g. when saving Product Image Placeholders.
Instead of expected values catalog/placeholder/image_placeholder, catalog/placeholder/ small_image_placeholder, catalog/placeholder/swatch_image_placeholder and catalog/placeholder/thumbnail_placeholder, all fields were saved to the catalog/placeholder/ placeholder.

Manual testing scenarios

  1. Configuration -> Catalog -> Catalog
  2. Open Product Image Placeholders tab
  3. Upload an image
  4. Save
  5. "Saved" image is missing after page load.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gelanivishal gelanivishal changed the title [Backport] Added $fieldId parameter into Config::getFieldPath method for fix of … [Backport] Fix of saving "clone_field" fields Oct 16, 2018
Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gelanivishal
Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3205 has been created to process this Pull Request

Fix new line EOF
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 17, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@maartenwolfsen
Copy link

I created a patch for this: https://gist.githubusercontent.com/maartenatmarissen/ecba171479af7f360942f64cf11355b2/raw/52f0255a1c1e6635765612ca6984d01eee9cf2ac/Config.php.patch.

Which can be applied using, for example: cweagans/composer-patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants