-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix of saving "clone_field" fields #18660
[Backport] Fix of saving "clone_field" fields #18660
Conversation
…"clone_field" system config feature.
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gelanivishal
Thanks for your contribution
Hi @rodrigowebjump, thank you for the review. |
Fix new line EOF
Hi @gelanivishal. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
I created a patch for this: https://gist.githubusercontent.com/maartenatmarissen/ecba171479af7f360942f64cf11355b2/raw/52f0255a1c1e6635765612ca6984d01eee9cf2ac/Config.php.patch. Which can be applied using, for example: cweagans/composer-patches |
Original Pull Request
#18160
Description
After the Config model's refactoring, which came with released version 2.2.6, there was an error in storing the fileds which were created using "clone_field" feature. When the values were stored, the path was wrong and the values were stored under the wrong key.
E.g. when saving Product Image Placeholders.
Instead of expected values
catalog/placeholder/image_placeholder
,catalog/placeholder/ small_image_placeholder
,catalog/placeholder/swatch_image_placeholder
andcatalog/placeholder/thumbnail_placeholder
, all fields were saved to thecatalog/placeholder/ placeholder
.Manual testing scenarios
Contribution checklist