Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport][2.3] of MAGETWO-93818: Magnifier function does not disappear after mouse-off the image from the bottom #18702

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

gwharton
Copy link
Contributor

@gwharton gwharton commented Oct 19, 2018

Original PR/Commit

c55480e#diff-a3d63022f922ef08dd75e31dddb0025a

This PR replicates the MAGETWO-93818 change into 2.3-develop

Description (*)

Magnifier function does not disappear after mouse-off the image from the bottom
This PR adds the onMouseLeave event

Fixed Issues (if relevant)

  1. [2.2.4] Gallery Magnifier hover event does not always cancel magnifier when mouse leaves gallery #15035: [2.2.4] Gallery Magnifier hover event does not always cancel magnifier when mouse leaves gallery

Manual testing scenarios (*)

  1. Enable magnifier zoom in themes view.xml
        <var name="magnifier">
            <var name="fullscreenzoom">20</var>  <!-- Zoom for fullscreen (integer)-->
            <var name="top"></var> <!-- Top position of magnifier -->
            <var name="left"></var> <!-- Left position of magnifier -->
            <var name="width"></var> <!-- Width of magnifier block -->
            <var name="height"></var> <!-- Height of magnifier block -->
            <var name="eventType">hover</var> <!-- Action that atcivates zoom (hover/click) -->
            <var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
            <var name="mode">outside</var> <!-- Zoom type (outside/inside) -->
        </var>

  1. Ensure that the magnifier cancels the zoom window when your mouse pointer leaves the product image.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…fter mouse-off the image from the bottom

Added onMouseLeave events
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gwharton gwharton changed the title [Forwardport] of MAGETWO-93818: Magnifier function does not disappear after mouse-off the image from the bottom [Forwardport][2.3] of MAGETWO-93818: Magnifier function does not disappear after mouse-off the image from the bottom Oct 19, 2018
@VladimirZaets VladimirZaets self-assigned this Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3224 has been created to process this Pull Request

@gwharton
Copy link
Contributor Author

@VladimirZaets sorry, I missed a whitespace issue that would result in a test fail. Just updated.

@magento-engcom-team magento-engcom-team merged commit 4b76ffd into magento:2.3-develop Oct 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
…does not disappear after mouse-off the image from the bottom #18702
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants