Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover \Magento\GiftMessage\Observer\SalesEventQuoteMerge with Unit test #18708

Merged

Conversation

vasilii-b
Copy link

Description

This PR cover \Magento\GiftMessage\Observer\SalesEventQuoteMerge plugin with unit test.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vasilii-b vasilii-b requested a review from rogyar October 19, 2018 19:04
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: GiftMessage Release Line: 2.3 labels Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 22, 2018
@magento-engcom-team magento-engcom-team merged commit fe600f2 into magento:2.3-develop Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GiftMessage Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants