Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 #18806

Closed
wants to merge 6 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2018

Description (*)

before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php

Fixed Issues (if relevant)

  1. Quote Item Prices are NULL in cart related events. #18685: Quote Item Prices are NULL in cart related events

Manual testing scenarios (*)

  1. create a module which has observers for these two events checkout_cart_product_add_after, checkout_cart_product_update_after cart
  2. now in the observer try to get the added item price by calling $observer->getEvent()->getQuoteItem()->getPrice()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18808

@magento-engcom-team
Copy link
Contributor

Hi @ashutoshwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link
Author

ghost commented Oct 25, 2018

#squashtoberfest

@VladimirZaets VladimirZaets self-assigned this Oct 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3272 has been created to process this Pull Request

@sidolov sidolov changed the title fixed Quote Item Prices are NULL in cart related events. #18685 [Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 Dec 22, 2018
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashutoshwebkul. Why your port contains more code changes than original Pull Request? What the reason for that?

@VladimirZaets
Copy link
Contributor

Hi @ashutoshwebkul, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @ashutoshwebkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants