[Backport] catalog:images:resize total images count calculates incorrectly #18387

[vpodorozh]

Original pull request (#18807)

Description (#18387)

Assumption from issue: >>"catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue".
However, there is a problem with total images count calculation select (distinct by image path is not used in count(*) ) - functionality by itself works correctly and process all images.

Fixed Issues

#18387: catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue

1. fixed getCountAllProductImages method that calculates total images count incorrectly;
2. covered \Magento\Catalog\Model\ResourceModel\Product\Image with unit tests;

UPD from 27.10.2018:
3. Ranged selects always miss the last range - [backport] of #12624

Manual testing scenarios

Variant I

1. Magento 2.3-develop
2. Sample data deployed (in order to easily have several test images in store)

Expected result

You do see total images count 801.

Actual result

You do see total images count 3422.

Variant II (synthetic case)

1. Magento 2.3-develop
2. Generate products iwth images:
   php bin/magento setup:performance:generate-fixtures setup/performance-toolkit/profiles/ce/medium.xml
3. apply the same image paths for all products - so images for product will become duplicated.
   For details check catalog_product_entity_media_gallery table.
   example SQL to do this:
   create temporary table zzz as (select NULL as value_id, c.attribute_id, c.value, c.media_type, c.disabled from catalog_product_entity_media_gallery as c); insert into catalog_product_entity_media_gallery select * from zzz;

Expected result

Total images count will be equal to the value from setup/performance-toolkit/profiles/ce/medium.xml in images-count node ( 1000 ).

Actual result

Total images count will be 2 times higher that their exact value.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @vpodorozh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[vpodorozh]

@duhon - The other Bug is present in 2.2-develop branch related to the current issue, check #18387 (comment) (I've updated PR description)

This issue #12624 has fixed problem with "Ranged selects always miss the last range" in 2.3-develop branch, however, backport to 2.2-develop branch was not made. So I've made it in the scope of current PR #18809 - you can check the fix here 76bd089 .

Could you please review my changes one more time?
Thank you and sorry for double check - issue become more complicated than it was expected.

[ghost]

Hi @vpodorozh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.