Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backoport] Issue Fixed: Backups error from User Roles Permission 2.2.6 #18815

Merged
merged 1 commit into from
Nov 9, 2018
Merged

[Backoport] Issue Fixed: Backups error from User Roles Permission 2.2.6 #18815

merged 1 commit into from
Nov 9, 2018

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Oct 25, 2018 •
edited by sidolov
Loading

Magento_Backup Module Permission issue fixed for Magento 2.2-develop.

Description (*)

If Admin Users assigned a Backup module Role Resource, Still was not able to access
Backups controller. Now its fixed.

Fixed Issues (if relevant)

  1. Backups error from User Roles Permission 2.2.6 #18150

Manual testing scenarios (*)

  1. Created a new Role Settings and assigned custom permission System->Tools.
  2. Logged in via the Sub admin user.
  3. Now Backup Controller is accessible.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18816

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

This was referenced Oct 25, 2018
Merged
Closed
@orlangur orlangur self-assigned this Oct 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3279 has been created to process this Pull Request

@sidolov sidolov changed the title Issue Fixed: Backups error from User Roles Permission 2.2.6 [Backoport] Issue Fixed: Backups error from User Roles Permission 2.2.6 Oct 30, 2018
@magento-engcom-team magento-engcom-team merged commit bf700aa into magento:2.2-develop Nov 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 9, 2018
ENGCOM-3279: Issue Fixed: Backups error from User Roles Permission 2.…
1da0438 
…2.6 #18815
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

magento-engcom-team added a commit that referenced this pull request Nov 12, 2018
@magento-engcom-team
ENGCOM-3280: Issue #18150 fixed: Reference Pull Request of #18815 for…
c69993c 
… 2.3-develop #18816

 - Merge Pull Request #18816 from maheshWebkul721/magento2:acl-issue
 - Merged commits:
   1. 3d0d8b7
magento-engcom-team pushed a commit that referenced this pull request Nov 12, 2018
ENGCOM-3280: Issue #18150 fixed: Reference Pull Request of #18815 for…
a1497f0 
… 2.3-develop #18816
magento-engcom-team added a commit that referenced this pull request Nov 12, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
57d7010 
Accepted Public Pull Requests:
 - #18814: Replace erroneous usage of unsData method (by @t-richards)
 - #19061: Fixed Product Tax total on PDF for 2.3, Reference of PL #18649 (by @maheshWebkul721)
 - #18816: Issue #18150 fixed: Reference Pull Request of #18815 for 2.3-develop  (by @maheshWebkul721)
 - #15961: 14294 - Fixes 'back' functionality after switching a store view. (by @Mobecls)


Fixed GitHub Issues:
 - #18617: Missing Fixed Product Tax total on PDF (reported by @Detzler) has been fixed in #19061 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. 73ff7cb

 - #18150: Backups error from User Roles Permission 2.2.6 (reported by @andy17612) has been fixed in #18816 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. 3d0d8b7

 - #14294: Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. (reported by @bobemoe) has been fixed in #15961 by @Mobecls in 2.3-develop branch
   Related commits:
     1. 3feda05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@brideo brideo Awaiting requested review from brideo

Assignees

@orlangur orlangur

Labels
Award: bug fix Component: Backup Progress: accept Progress: on hold Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@mahesh-rajawat @magento-engcom-team @orlangur @sidolov