Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #1 from magento/2.3-develop #18861

Closed
wants to merge 3 commits into from
Closed

Merge pull request #1 from magento/2.3-develop #18861

wants to merge 3 commits into from

Conversation

saphaljha
Copy link
Contributor

@saphaljha saphaljha commented Oct 27, 2018 •
edited
Loading

updated for 2.3.x

Description (*)

18192 Backend issue : "ratings isn't available" website wise

Fixed Issues (if relevant)

  1. Backend issue : "ratings isn't available" website wise #18192: Backend issue : "ratings isn't available" website wise
  2. ...

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Oct 27, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 27, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

orlangur
orlangur requested changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saphaljha please get rid of useless merge commits and fix pull request title.

@saphaljha saphaljha closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

Assignees
No one assigned
Labels
Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saphaljha @magento-cicd2 @orlangur @magento-engcom-team