Fixed rating issue website wise #18888
Conversation
updated for 2.3.x
Update repo
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
|
Hi @saphaljha. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@saphaljha get rid of useless merge commits, please. |
| /** | ||
| * @var \Magento\Framework\App\State | ||
| */ | ||
| protected $_state; |
There was a problem hiding this comment.
Hi, @saphaljha, due to Magento Technical guidelines we can't introduce protected properties. All new properties should be private.
There was a problem hiding this comment.
Hello @VladimirZaets , Thank you for your guidance, I'll check and update it asap.
| @@ -48,12 +54,14 @@ public function __construct( | |||
| \Magento\Framework\Module\Manager $moduleManager, | |||
| \Magento\Store\Model\StoreManagerInterface $storeManager, | |||
| \Magento\Review\Model\ResourceModel\Review\Summary $reviewSummary, | |||
| \Magento\Framework\App\State $state, | |||
There was a problem hiding this comment.
Due to Magento backward-compatible guide we can't add new required parameters to constructor.
There was a problem hiding this comment.
Hello @VladimirZaets , I'll check and update it asap.
| @@ -425,9 +433,11 @@ public function getReviewSummary($object, $onlyForCurrentStore = true) | |||
|
|
|||
| $data = $connection->fetchAll($select, [':review_id' => $object->getReviewId()]); | |||
|
|
|||
| $currentStore = ($this->_state->getAreaCode() == "adminhtml") ? false : $this->_storeManager->getStore()->getId(); | |||
There was a problem hiding this comment.
I think we should use an existing constant for providing area name.
Also, please use NULL instead of false, we shouldn't mix types of variable. Store id is number or null type, but not false
There was a problem hiding this comment.
Hello @VladimirZaets , I'll check and update it asap.
|
Hi @sidolov, thank you for the review. |
|
@saphaljha thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @saphaljha. Thank you for your contribution. |
Description (*)
Fixed rating issue website wise.
Fixed Issues (if relevant)
Manual testing scenarios (*)
N/A
Contribution checklist (*)