Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] #17890: show correct text swatch values per store view #18988

Merged
merged 1 commit into from
Nov 6, 2018
Merged

[Forwardport] #17890: show correct text swatch values per store view #18988

merged 1 commit into from
Nov 6, 2018

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#17891

Description

Show correct text swatches values per store view.

Fixed Issues (if relevant)

  1. Magento 2.2.5 Product swatches does not shows correct value for related store view #17890: Magento 2.2.5 Product swatches does not shows correct value for related store view

Manual testing scenarios

  1. Install fresh magento with default simple data
  2. Edit swatch values for size attribute.
  3. Change value for default store to XS D. And for admin store set XS A
    image
  4. Run bin/magento index:reindex to reindex all indexes
  5. Run bin/magento cache:clean block_html full_page
  6. Open product view page on frontend SKU=MH01
  7. Value of size attribute should have XS D value instead of XS A
    image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 1, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3360 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants