Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3-develop] magento/magento2#14007: "Use in Layered Navigation: Filterable (no results)" property confuse for Price filter #19037

Conversation

vpodorozh
Copy link
Contributor

@vpodorozh vpodorozh commented Nov 2, 2018

Description (#14007)

"Use in Layered Navigation: Filterable (no results)" not working for Price attribute.

  • adjust comment for "Use in Layered Navigation: Filterable (no results)" property to make it more understandable

Fixed Issues

No issues were fixed - only adjusted "Use in Layered Navigation: Filterable (no results)" property note/comment to make it more understandable and dismiss confusion about its effect on Price attribute/filter

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

"Use in Layered Navigation: Filterable (no results)" not working for `Price` attribute.
- adjust comment for "Use in Layered Navigation: Filterable (no results)" property to make it more understandable
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: LayeredNavigation labels Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Here is the appearance:
image

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3389 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: LayeredNavigation Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants