-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#18840: Invalid Unit Test Annotations. #19105
Conversation
Hi @swnsma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swnsma this should be a backport preserving original commit author. Please fix it using force push.
- fixed invalid unit tests annotations that assert exception messages - backport to 2.2.
f79ccb7
to
252a0ed
Compare
Author has been changed. |
Hi @orlangur, thank you for the review. |
Hi @swnsma. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description (*)
Fixed invalid unit tests annotations that assert exception messages. With these changes, unit tests will assert exception messages correctly
Backport to 2.2.
Fix commit in accordance to 2.2 exception messages.
Fixed Issues (if relevant)
Manual testing scenarios (*)
No manual testing neede. All changes are covered with unit tests
Contribution checklist (*)