Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#18840: Invalid Unit Test Annotations. #19105

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Nov 7, 2018

Description (*)

Fixed invalid unit tests annotations that assert exception messages. With these changes, unit tests will assert exception messages correctly
Backport to 2.2.
Fix commit in accordance to 2.2 exception messages.

Fixed Issues (if relevant)

  1. Invalid Unit Test Annotations #18840: Invalid Unit Test Annotations

Manual testing scenarios (*)

No manual testing neede. All changes are covered with unit tests

Contribution checklist (*)

  • [] Pull request has a meaningful description of its purpose
  • [] All commits are accompanied by meaningful commit messages
  • [] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: multiple Release Line: 2.2 labels Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Nov 7, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swnsma this should be a backport preserving original commit author. Please fix it using force push.

 - fixed invalid unit tests annotations that assert exception messages
 - backport to 2.2.
@swnsma
Copy link
Contributor Author

swnsma commented Nov 7, 2018

Author has been changed.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3410 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: multiple Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants