issue #18349 Fixed for 2.3: Incorrect quote_item_id saved on order items during multiple address checkout

[mahesh-rajawat]

Incorrect quote_item_id saved on order items during multiple address checkout issue fixed.

Description (*)

When order placed using Multiple address checkout then there were incorrect quote_item_id in
sales_order_item table.

Fixed Issues (if relevant)

1. Incorrect quote_item_id saved on order items during multiple address checkout #18349

Manual testing scenarios (*)

1. Placed and Order with Multi address checkout, now quote_item_id is correct.
2. Placed an order with Onestep checkout quote_item_id is correct as well.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @maheshWebkul721 Thank you for the contribution. I think it might be more consistent to introduce this change in declarative way to

magento2/app/code/Magento/Quote/etc/fieldset.xml

Lines 208 to 210 in 069d5cd

	<field name="id">
	<aspect name="to_order_item" targetField="quote_item_id" />
	</field>

[sivaschenko]

Thank you for collaboration! Please see the suggestion for implementation improvement

[mahesh-rajawat]

@sivaschenko suggestion implemented, i have found another bug with this procedure, Store id is also
not saved it always saved NULL (Screenshot: https://prnt.sc/lkrfbk ) with Multishipping Checkout. I am working on that point also.
I think, it will be good to Create new PR for that.

[sivaschenko]

Thank you for the updates. Please fix the final required cosmetic change and it would be good to squash the commits into one for the delivery

[sivaschenko]

@maheshWebkul721 thanks! Nice catch with the store id!

[mahesh-rajawat]

Hi @sivaschenko , updated the declaration syntax, please review now. Thanks for all your help.

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3503 has been created to process this Pull Request

[mahesh-rajawat]

Hi @sivaschenko, i have fixed the store_id issue as well in PR #19321 .

[ghost]

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.