Don't return categoryId from registry if the product doesn't belong in the current category

[ErikPel]

Description (*)

I added is_array check to \Magento\Catalog\Model\Product:getCategoryId that check whether the product belongs to the current_category set in registry. This fixes getProductUrl function not returning correct url since there isn't url rewrite for product in that category.

Fixed Issues (if relevant)

1. Wrong product url from getProductUrl when current category has not product object #17819: Wrong product url from getProductUrl when current category has not product object

Manual testing scenarios (*)

1. Create two category category1 and category2 with url-keys category-1 and category-2 respectively
2. Create product with url key product-1, assign it to category1
3. Add created categories to topmenu (turn on "include to menu" checkbox)
4. Create custom module Vendor_Module I have example here if you want to get it fast https://github.com/ErikPel/17819-TestScenario
5. Create template; add it to category layout
6. In the template get product collection with all products in it
7. In foreach loop call $product->getCategory() or $product->getProductUrl()
8. Before getCategory would return the current_category from registry even though the product doesn't belong to the category we are in. And getProductUrl would return http://example.com/catalog/product/view/id/1/s/product-1/category/2 instead of http://example.com/product-1

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @ErikPel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

@ErikPel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[okorshenko]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @okorshenko, here is your new Magento instance.
Admin access: http://34.228.235.121/pr-19232//admin
Login: admin Password: 123123q

[slavvka]

Hey @ErikPel Could you please take a look at failing integration tests?

[ErikPel]

Hey @ErikPel Could you please take a look at failing integration tests?

Fixed the integration tests

[magento-engcom-team]

Hi @ErikPel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.