Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport]Fix-issue-19399-Add product customization option collapsible design issue #19400

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Nov 24, 2018

Original Pull Request

#19405

Description (*)

Add product customization option collapsible design issue

Fixed Issues (if relevant)

1.#19399 : Add product customization option collapsible design issu

Manual testing scenarios (*)

1.Go to -> Catalog Product -> add product from backend
2.Go to -> customization option.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Nov 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Nov 26, 2018

Hi @speedy008. Thank you for the fix. We can accept changes to 2.2-develop branch only if the changes are present in 2.3-develop branch. Since the issue is reproducible on 2.3-develop branch, please, consider creating the same PR to the 2.3-develop branch and mark the current PR as backport (change the title). Thank you

@rogyar rogyar self-assigned this Nov 26, 2018
@speedy008 speedy008 changed the title Fix-issue-19399-Add product customization option collapsible design issue [Backport]Fix-issue-19399-Add product customization option collapsible design issue Nov 26, 2018
@speedy008 speedy008 added the Port label Nov 26, 2018
@speedy008
Copy link
Contributor Author

Hi @rogyar
I have updated this PR as Backport In 2.2-develop branch.
and created Origin PR in 2.3-develop branch.

@ghost
Copy link

ghost commented Jan 23, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants