Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 19507 - Frontend Minicart dropdown alignment issue #19508

Merged
merged 6 commits into from
Dec 22, 2018
Merged

Fix issue 19507 - Frontend Minicart dropdown alignment issue #19508

merged 6 commits into from
Dec 22, 2018

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Dec 1, 2018 •
edited
Loading

Description (*)

Frontend Minicart dropdown alignment issue

Fixed Issues (if relevant)

1.#19507: Frontend Minicart dropdown alignment issue

Manual testing scenarios (*)

1.Check Minicart dropdown alignment

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor

Karlasa commented Dec 1, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-19508.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@speedy008
Copy link
Contributor Author

Hi @Karlasa
I have updated CSS code Please review it.

@VladimirZaets VladimirZaets self-assigned this Dec 3, 2018
Karlasa
Karlasa approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking, you did great job. Well done :)

@speedy008 speedy008 added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Dec 20, 2018
@speedy008 speedy008 mentioned this pull request Dec 20, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3721 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 22, 2018 00:35
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 22, 2018 00:35
@magento-engcom-team magento-engcom-team mentioned this pull request Dec 22, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit e864a0c into magento:2.3-develop Dec 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 22, 2018
@sidolov
ENGCOM-3721: Fix issue 19507 - Frontend Minicart dropdown alignment i…
25634d6 
…ssue #19508
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlasa Karlasa Karlasa approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@speedy008 @magento-engcom-team @Karlasa @VladimirZaets