Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix typo in SQL join when joining custom option prices for price indexer [2.2] #19552

Conversation

udovicic
Copy link
Member

@udovicic udovicic commented Dec 4, 2018

Description (*)

In case where product has price variation for custom option per website, only default value (store_id = 0) is taken into an account due to typo in SQL statement.

NOTE: This is a copy of #19546, but for a 2.2-develop.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

This one is pretty obvious from diff, but...

  1. Create scenario where simple product price is regulated per website and have at least two websites
  2. Set default price to amount X
  3. Set price of custom option (on default view) to amount to Y
  4. Switch scope to another website and set price of custom option to be 0
  5. Execute price indexer
  6. Difference between min and max price should be visible only on one website, however all websites will have this difference

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @udovicic. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

@udovicic thanks for your contribution, this pull request will be processed after #19546 is merged

@sivaschenko sivaschenko changed the title Fix typo in SQL join when joining custom option prices for price indexer [2.2] [Backport] Fix typo in SQL join when joining custom option prices for price indexer [2.2] Dec 5, 2018
@orlangur orlangur self-assigned this Dec 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3622 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@sivaschenko
Copy link
Member

Hi @udovicic can you please include static tests fix commit c1be7d8 from the 2.3 PR in this backport

@udovicic
Copy link
Member Author

@sivaschenko Changes have been pushed

@sivaschenko
Copy link
Member

@udovicic thank you

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 6, 2019
@magento-engcom-team magento-engcom-team merged commit 8f39be8 into magento:2.2-develop Mar 6, 2019
@ghost
Copy link

ghost commented Mar 6, 2019

Hi @udovicic, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants