Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added config for wishlist sidebar in config #19554

Merged
merged 3 commits into from
Dec 9, 2018
Merged

added config for wishlist sidebar in config #19554

merged 3 commits into from
Dec 9, 2018

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Dec 4, 2018

Description

Until now there wasn't a config field to hide wishlist from sidebar.

Manual testing scenarios

  1. Open Backend
  2. Go to Stores -> Configuration -> Customers -> Wish List
  3. Set 'Show in Sidebar' to 'No'
  4. Wishlist will be hidden from sidebar

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento magento deleted a comment from magento-cicd2 Dec 4, 2018
@magento magento deleted a comment from magento-engcom-team Dec 4, 2018
@magento magento deleted a comment from magento-engcom-team Dec 4, 2018
@torhoehn
Copy link
Contributor Author

torhoehn commented Dec 4, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-19554.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor

Karlasa commented Dec 4, 2018

@torhoehn Great idea 👍
Maybe update en_US.csv file also? :)

@torhoehn
Copy link
Contributor Author

torhoehn commented Dec 4, 2018

@torhoehn Great idea 👍
Maybe update en_US.csv file also? :)

@Karlasa
Of course, updated it!

@sivaschenko sivaschenko self-assigned this Dec 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3617 has been created to process this Pull Request

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torhoehn please see my code update suggestion. Currently there is an exception on Stores Configuration page as system.xml does not pass the validation

app/code/Magento/Wishlist/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
Co-Authored-By: torhoehn <torhoehn@gmail.com>
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@torhoehn torhoehn deleted the feature/show-wishlist-in-sidebar branch December 9, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants