Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Custom option price calculation is wrong with multi currency when option price type is percentage #19608

Merged
merged 4 commits into from Feb 15, 2019
Merged

Fixed Custom option price calculation is wrong with multi currency when option price type is percentage #19608

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7fb186
Fixed Custom option price calculation is wrong with multi currency wh…
Dec 7, 2018
4d84a7a
solved fixed price calculation
Dec 7, 2018
8bdedc5
Update Code for Price Calculation
Feb 9, 2019
fde7fb1
ENGCOM-4217: Static test fix.
p-bystritsky Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/code/Magento/Catalog/Block/Product/View/Options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
*/
class Options extends \Magento\Framework\View\Element\Template
{
/**
* Option type percent
*/
protected static $typePercent = 'percent';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleare reuse \Magento\Catalog\Model\Product\Option\Value::TYPE_PERCENT instead of introducing this property


/**
* @var Product
*/
Expand Down Expand Up @@ -160,6 +165,7 @@ public function hasOptions()
*/
protected function _getPriceConfiguration($option)
{
$option->getPriceType() == self::$typePercent ? $optionPrice = $option->getPrice(true) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to simplify the code here to be easier to read, like:

       $optionPrice = $option->getPrice(true);
       If ($option->getPriceType() != Value::TYPE_PERCENT) {
           $optionPrice = $this->pricingHelper->currency($optionPrice, false, false);
       }

$optionPrice = $this->pricingHelper->currency($option->getPrice(true), false, false);
$data = [
'prices' => [
Expand Down Expand Up @@ -195,7 +201,7 @@ protected function _getPriceConfiguration($option)
],
],
'type' => $option->getPriceType(),
'name' => $option->getTitle()
'name' => $option->getTitle(),
];
return $data;
}
Expand Down Expand Up @@ -231,7 +237,7 @@ public function getJsonConfig()
//pass the return array encapsulated in an object for the other modules to be able to alter it eg: weee
$this->_eventManager->dispatch('catalog_product_option_price_configuration_after', ['configObj' => $configObj]);

$config=$configObj->getConfig();
$config = $configObj->getConfig();

return $this->_jsonEncoder->encode($config);
}
Expand Down