Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Fixed checkbox alignment #19631

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Checkbox alignment issue backend.

Fixed Issues (if relevant)

  1. Checkbox alignment issue backend. #19630: Checkbox alignment issue backend.

Manual testing scenarios (*)

  1. Login into admin panel > System > Export > checkbox alignment issue "Fields Enclosure".

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3642 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 19, 2018 18:34
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 19, 2018 18:34
@sivaschenko
Copy link
Member

Hi @suryakant-krish these changes were already contributed by you in #19413 . Please ensure no additional changes needed and close this PR and corresponding issue as duplicates.

@suryakant-krish
Copy link
Contributor Author

@sivaschenko,

Please review this PR.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19631.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Thanks @suryakant-krish , I can consider this pull request as a cleanup of original solution

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants