Patch 18017 magento 23 #19635

niravkrish · 2018-12-08T06:36:51Z

Description (*)

When pre-selecting a configurable product swatch that has an image, Magento will try to load that image in the product gallery before it is initialized, throwing a JavaScript error.

Fixed Issues (if relevant)

URL pre-selection of configurable product swatches with associated product images throws JavaScript error #18017: URL pre-selection of configurable product swatches with associated product images throws JavaScript error

Manual testing scenarios (*)

Hit Url With Url domain.com/montana-wind-jacket.html#93=53
Hit Url With Url domain.com/montana-wind-jacket.html#93=58
Test with normal configurable product on listing page as well as on Product Details Page

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-12-08T06:37:02Z

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur · 2018-12-09T00:03:25Z

app/code/Magento/Swatches/view/frontend/web/js/swatch-renderer.js

@@ -1223,7 +1223,14 @@ define([
                }

                imagesToUpdate = this._setImageIndex(imagesToUpdate);
-                gallery.updateData(imagesToUpdate);
+                if (gallery === undefined) {


Such check is not correct, please use typeof instead.

I will update the code.
Please review It.

magento-engcom-team · 2018-12-11T10:12:36Z

Hi @VladimirZaets, thank you for the review.
ENGCOM-3665 has been created to process this Pull Request

orlangur · 2018-12-11T13:09:48Z

@VladimirZaets shouldn't this be typeof gallery === 'undefined' instead of typeof gallery === undefined?

sdzhepa · 2019-01-17T14:05:06Z

Hello @niravkrish
During testing our QA engineer faced an issue.
Could you please have a look and fix it?

Please see the quote of QA comment after testing on branch with the PR

PR doesn't fix issue #18017

Manual testing scenario:

Create two option for configurable product based on Visual Swatch attribute
Set Use Web Server Rewrites=No
Open the configurable product page, with the option pre-selected.
magento_site/index.php/conf1.html#135=4

Actual Result: Not OK,

Thank you for contribution and collaboration

VladimirZaets · 2019-01-30T21:48:18Z

@niravkrish, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

ghost · 2019-01-30T21:48:19Z

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

niravkrish · 2019-01-31T08:42:25Z

Hello,

Please review and test issue.

I have already resolve gallery image change issue in resolve conflicts my last commit ( resolve conflicts - bbceaab ).

VladimirZaets · 2019-02-05T17:56:37Z

Hi, @niravkrish. As I see the merge conflict exists. Please resolve it.

… 2 core file

VladimirZaets · 2019-02-20T16:03:11Z

@niravkrish thanks.

VasylShvorak · 2019-03-04T07:22:14Z

✔️ QA passed

ghost · 2019-03-14T19:46:54Z

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed-magento#18017 magento 2.3

b92bbc4

magento-engcom-team added Area: Frontend Component: Swatches Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 8, 2018

Fixed Code Improovement

95d5f44

orlangur reviewed Dec 9, 2018

View reviewed changes

sidolov added the Progress: needs update label Dec 9, 2018

niravkrish added 2 commits December 10, 2018 10:02

Code Improovement and changes as suggested

30c3eac

code changes as per PSR4

ee64ecd

VladimirZaets self-assigned this Dec 11, 2018

VladimirZaets removed the Progress: needs update label Dec 11, 2018

VladimirZaets approved these changes Dec 11, 2018

View reviewed changes

magento-engcom-team added this to the Release: 2.3.1 milestone Dec 11, 2018

niravkrish added 2 commits December 28, 2018 13:03

Code Improvement suggested by orlangur

7feaedd

resolve conflicts

bbceaab

sdzhepa added the Progress: needs update label Jan 17, 2019

magento-engcom-team removed the Progress: needs update label Jan 17, 2019

sdzhepa added the Progress: needs update label Jan 21, 2019

okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019

VladimirZaets closed this Jan 30, 2019

niravkrish reopened this Jan 31, 2019

niravkrish and others added 3 commits February 6, 2019 15:25

reolve comflict and remove unncessary code using compare with magento…

0611394

… 2 core file

Merge branch '2.3-develop' into patch-18017-magento-23

41c2d90

Merge branch '2.3-develop' into patch-18017-magento-23

ec5c01f

VladimirZaets removed the Progress: needs update label Feb 20, 2019

sidolov added the Progress: ready for testing label Feb 28, 2019

VasylShvorak self-assigned this Mar 1, 2019

p-bystritsky self-assigned this Mar 6, 2019

sidolov added Progress: extended testing and removed Progress: ready for testing labels Mar 6, 2019

ghost added Progress: accept and removed Progress: extended testing labels Mar 7, 2019

magento-engcom-team mentioned this pull request Mar 14, 2019

URL pre-selection of configurable product swatches with associated product images throws JavaScript error #18017

Closed

magento-engcom-team merged commit ec5c01f into magento:2.3-develop Mar 14, 2019

magento-engcom-team added this to the Release: 2.3.2 milestone Mar 14, 2019

magento-engcom-team pushed a commit that referenced this pull request Mar 14, 2019

ENGCOM-4296: Patch 18017 magento 23 #19635

ec90be5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch 18017 magento 23 #19635

Patch 18017 magento 23 #19635

niravkrish commented Dec 8, 2018

magento-engcom-team commented Dec 8, 2018

orlangur Dec 9, 2018

niravkrish Dec 10, 2018

magento-engcom-team commented Dec 11, 2018

orlangur commented Dec 11, 2018

sdzhepa commented Jan 17, 2019

VladimirZaets commented Jan 30, 2019

ghost commented Jan 30, 2019

niravkrish commented Jan 31, 2019 •

edited

Loading

VladimirZaets commented Feb 5, 2019

VladimirZaets commented Feb 20, 2019

VasylShvorak commented Mar 4, 2019

ghost commented Mar 14, 2019

Patch 18017 magento 23 #19635

Patch 18017 magento 23 #19635

Conversation

niravkrish commented Dec 8, 2018

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Dec 8, 2018

orlangur Dec 9, 2018

Choose a reason for hiding this comment

niravkrish Dec 10, 2018

Choose a reason for hiding this comment

magento-engcom-team commented Dec 11, 2018

orlangur commented Dec 11, 2018

sdzhepa commented Jan 17, 2019

VladimirZaets commented Jan 30, 2019

ghost commented Jan 30, 2019

niravkrish commented Jan 31, 2019 • edited Loading

VladimirZaets commented Feb 5, 2019

VladimirZaets commented Feb 20, 2019

VasylShvorak commented Mar 4, 2019

ghost commented Mar 14, 2019

niravkrish commented Jan 31, 2019 •

edited

Loading