Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19575 magentoDataFixture should allow to use Module Prefix - Integrations Test #19679

Merged
merged 3 commits into from
Feb 18, 2019
Merged

#19575 magentoDataFixture should allow to use Module Prefix - Integrations Test #19679

merged 3 commits into from
Feb 18, 2019

Conversation

larsroettig
Copy link
Member

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#19575

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @larsroettig , thanks for your contribution. There is a static test fail. As this is an exceptional case and if there is no backward compatible way to retrive the required component registrar without static call, I think we should add a @SuppressWarnings(PHPMD.StaticAccess) annotation

@larsroettig
Copy link
Member Author

@sivaschenko done 👍

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3657 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @larsroettig, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2019
fooman added a commit to fooman/magento2 that referenced this pull request Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants