Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling #19684

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Dec 10, 2018

Description (*)

correct spelling

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3656 has been created to process this Pull Request

@orlangur
Copy link
Contributor

@ravi-chandra3197 please do not produce useless merge commits.

@ravi-chandra3197
Copy link
Contributor Author

Hello @orlangur
Any suggestion for how to remove merge commits.

@orlangur
Copy link
Contributor

@ravi-chandra3197
Copy link
Contributor Author

@orlangur Thanks for the response but my concern is how to remove commit from an existing branch or rewrite branch history.

@orlangur
Copy link
Contributor

@ravi-chandra3197 simply squash all changes into single commit and force push as provided article shows.

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 12, 2018 00:18
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 12, 2018 00:18
@ravi-chandra3197
Copy link
Contributor Author

Hello, @orlangur I have removed merge commits. can review it.

@orlangur
Copy link
Contributor

@ravi-chandra3197 very nice, thank you! 👍

@magento-engcom-team magento-engcom-team merged commit 37db806 into magento:2.3-develop Dec 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants