Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lib-url-check() function from lib docs LESS #19778

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#19412

was removed as this function does not exist anymore

Description (*)

lib-url-check was removed from lib/web/source before and also later from docs. As it was not removed from docs less files it now breaks "grunt exec" command as this function does not exist nowhere.

connected PR:
#17479 - removes it from Docs
#11371 - removes from source Less

Fixed Issues (if relevant)

Manual testing scenarios (*)

Grunt exec will not fail after change

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

was removed as this function does not exist anymore
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3696 has been created to process this Pull Request

@orlangur
Copy link
Contributor

@sivaschenko such cleanup is not needed in 2.2 according to Magento Code Contributions Guide

@sivaschenko
Copy link
Member

@orlangur this is not a cleanup, this is a fix for grunt exec

@sivaschenko
Copy link
Member

@gelanivishal thanks for the port, however, the issue with grunt exec cannot be reproduced on 2.2 so this pull request should not be merged to 2.2. Closing. Do not hesitate to contact me if you think that's incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants