Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Changing sample for downloadable product failure #19806

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Fixed Changing sample for downloadable product failure #19806

merged 3 commits into from
Apr 23, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Dec 15, 2018 •
edited
Loading

Description (*)

Fixed Changing sample for downloadable product failure

Fixed Issues (if relevant)

  1. Changing sample for downloadable product failure #6272: Changing sample for downloadable product failure

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Dec 16, 2018
@ravi-chandra3197
Copy link
Contributor Author

Hello @orlangur
I have updated my code can review it.

1 similar comment
@ravi-chandra3197
Copy link
Contributor Author

Hello @orlangur
I have updated my code can review it.

orlangur
orlangur requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

@ravi-chandra3197
Copy link
Contributor Author

Hello @orlangur
I have squash changes into a single commit.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4684 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 11, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 12, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 23, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit d598262 into magento:2.3-develop Apr 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 23, 2019
@sivaschenko
ENGCOM-4684: Fixed Changing sample for downloadable product failure #…
26e3142 
…19806
@ravi-chandra3197 ravi-chandra3197 mentioned this pull request Apr 24, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: Downloadable Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ravi-chandra3197 @magento-engcom-team @VasylShvorak @orlangur @p-bystritsky