Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19482 increase product quantity with disabled manage stock when place order is failed #19997

Conversation

agorbulin
Copy link

Magento increments stock for products for which stock managing is disabled in case, when restore stock qty after failed placing order

Fixed Issues (if relevant)

  1. Increase product quantity with disabled Manage Stock when place order is failed #19482: Increase product quantity with disabled Manage Stock when place order is failed

Manual testing scenarios (*)

  1. In the admin panel set for a product Manage Stock: No and Quantity: 100
  2. Place an order with this product via PayPal, but with a card that does not have enough money to pay for the order
    Expected result:
    Product Quantity is 100

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Oleksii Gorbulin added 2 commits December 27, 2018 23:54
…-order-is-failed

Magento2:magento#19482 Increase product quantity with disabled Manage Stock when place order is failed
…-order-is-failed

Increase product quantity with disabled Manage Stock when place order is failed magento#19482
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: CatalogInventory Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Dec 27, 2018
@VladimirZaets VladimirZaets self-assigned this Dec 31, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 31, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3771 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 26, 2019

Hi @agorbulin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: CatalogInventory Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants