#13612 Fixed-Quantity_and_stock_status when visibility set to storefront throwing exception

[aditisinghcedcoss]

Description (*)

The function getOptionText expects params as string or integer and in case of quantity_and_stock_status when visibility set to storefront , array passed to getOptionText which can be handled by adding is_scalar check for param $value.

Fixed Issues (if relevant)

1. magento/magento2 1 exception(s): Exception #0 (Exception): Warning: Illegal offset type in isset or empty in /home/jewelrynest2/public_html/magento/vendor/magento/module-eav/Model/Entity/Attribute/Source/AbstractSource.php on line 76 #13612: Issue 1 exception(s): Exception #0 (Exception): Warning: Illegal offset type in isset or empty in /Model/Entity/Attribute/Source/AbstractSource.php on line 76

Manual testing scenarios (*)

Contribution checklist (*)

• [ x] Pull request has a meaningful description of its purpose
• [ x] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @aditisinghcedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Hi @aditisinghcedcoss,

Array keys can only be scalar, but $value is an array.

It looks like it's enough to check is_scalar($value). Please update code and do amend commit.

Condition like is_null($value) === false looks really odd and is never a good idea.

[aditisinghcedcoss]

@orlangur sir,

i have made the amendments.

Thank you.

[orlangur]

@aditisinghcedcoss, only those checks are needed:

is_scalar($value) && isset($options[$value])

Please squash changes into a single commit and do a force push.

[aditisinghcedcoss]

@orlangur sir,

I have squashed changes into a single commit and forced pushed.

Thank you.

[aditisinghcedcoss]

@orlangur sir,

Please Review.

Thank you

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3810 has been created to process this Pull Request

[magento-engcom-team]

@aditisinghcedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @aditisinghcedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[meker12]

Draft release note:

Infrastructure

Added an is_array parameter value check to the getOptionText($value) function in app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php to fix an error that caused Magento to throw a UI error when you change the quantity_and_stock_status (Qty) product attribute visibility settings in the Storefront properties. Previously, the getOptionText($value)` function expected integer or string input and failed if parameters were passed as an array.