Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed Incorrect class name on Orders and returns page. #20080

Merged
merged 1 commit into from
Jan 10, 2019
Merged

[Backport] Fixed Incorrect class name on Orders and returns page. #20080

merged 1 commit into from
Jan 10, 2019

Conversation

shikhamis11
Copy link
Member

Original Pull Request

#19784
Fixed #19780
Incorrect class name on Orders and returns page.

Summary (*)

On 'Orders and returns' page legend tag has class admin__legend as on admin area.
Examples (*)

app/code/Magento/Sales/view/frontend/templates/guest/form.phtml

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed #19780
Incorrect class name on Orders and returns page.
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3791 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9480a63 into magento:2.2-develop Jan 10, 2019
@ghost
Copy link

ghost commented Jan 10, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@shikhamis11 shikhamis11 deleted the 2.2-develop-PR-port-19784 branch January 10, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants