Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #20157 On advanced search page Price field misaligned on mobile view #20159

Merged
merged 4 commits into from
Feb 10, 2019
Merged

Fixed issue #20157 On advanced search page Price field misaligned on mobile view #20159

merged 4 commits into from
Feb 10, 2019

Conversation

GovindaSharma
Copy link
Contributor

Description (*)

Fixed issue #20157 On advanced search page Price field misaligned on mobile view

Fixed Issues (if relevant)

  1. magento/magento2 On advanced search page Price field misaligned on mobile view #20157: On advanced search page Price field misaligned on mobile view

Manual testing scenarios (*)

  1. click on footer link "advanced search" check for price field mobile view.
  2. Check Price Field ,it is not properly aligned

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed issue #20157
47f5132 
Updated css file
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jan 10, 2019
VladimirZaets
VladimirZaets reviewed Jan 10, 2019
View reviewed changes
app/design/frontend/Magento/luma/Magento_CatalogSearch/web/css/source/_module.less Outdated
@@ -18,6 +18,20 @@
// _____________________________________________

& when (@media-common = true) {

.search{
.fieldset{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GovindaSharma. Thanks for collaboration. Please fix indents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets please check ,i have fixed indents long time ago

@GovindaSharma
Copy link
Contributor Author

@VladimirZaets i have fixed the indents.Please check it.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3991 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 10, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 10f5378 into magento:2.3-develop Feb 10, 2019
@ghost
Copy link

ghost commented Feb 10, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 10, 2019
@sidolov
ENGCOM-3991: Fixed issue #20157 On advanced search page Price field m…
21b358e 
…isaligned on mobile view #20159
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Feb 10, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Feb 11, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets left review comments

@sidolov sidolov sidolov approved these changes

Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels
Area: Design/Frontend Award: bug fix Community Insider: Cedcommerce community-insider-contribution Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@GovindaSharma @magento-engcom-team @VladimirZaets @sidolov @okorshenko @p-bystritsky