Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order API resources updated. #20169 #20170

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Order API resources updated. #20169 #20170

merged 1 commit into from
Jan 23, 2019

Conversation

milindsingh
Copy link
Member

@milindsingh milindsingh commented Jan 10, 2019 •
edited
Loading

Description (*)

Fixed Issues (if relevant)

  1. Admin user with restricted "order create" access can "view", "cancel", etc via API #20169: Admin user with restricted "order create" access can "view", "cancel", etc via API

Manual testing scenarios (*)

  1. Validate Order API actions

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

sivaschenko
sivaschenko requested changes Jan 10, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @milindsingh thanks for the contribution! Please see my code review notes

app/code/Magento/Sales/etc/webapi.xml Outdated
</resources>
</route>
<route url="/V1/invoices/:id/void" method="POST">
<service class="Magento\Sales\Api\InvoiceManagementInterface" method="setVoid"/>
<resources>
<resource ref="Magento_Sales::sales" />
<resource ref="Magento_Sales::sales_invoice" />
<!--TODO: review-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, please remove the TODO

app/code/Magento/Sales/etc/webapi.xml Outdated
</resources>
</route>
<route url="/V1/transactions/:id" method="GET">
<service class="Magento\Sales\Api\TransactionRepositoryInterface" method="get"/>
<resources>
<resource ref="Magento_Sales::sales" />
<resource ref="Magento_Sales::transactions" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Magento_Sales::transactions_fetch is more appropriate for viewing transactions (read only).

app/code/Magento/Sales/etc/webapi.xml Outdated
</resources>
</route>
<route url="/V1/transactions" method="GET">
<service class="Magento\Sales\Api\TransactionRepositoryInterface" method="getList"/>
<resources>
<resource ref="Magento_Sales::sales" />
<resource ref="Magento_Sales::transactions" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Magento_Sales::transactions_fetch is more appropriate for viewing transactions (read only).

app/code/Magento/Sales/etc/webapi.xml Outdated
</resources>
</route>
<route url="/V1/orders/:id/comments" method="GET">
<service class="Magento\Sales\Api\OrderManagementInterface" method="getCommentsList"/>
<resources>
<resource ref="Magento_Sales::sales" />
<resource ref="Magento_Sales::comment" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Magento_Sales::actions_view here, considering that Magento_Sales::comment is used only for adding comments currently?

@sivaschenko sivaschenko self-assigned this Jan 10, 2019
@milindsingh
Copy link
Member Author

@sivaschenko Thanks for the review. I have updated the code as suggested.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3834 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Jan 23, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 4b0eeb6 into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@sidolov
ENGCOM-3834: Order API resources updated. #20169 #20170
5306a5b
@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@irajneeshgupta irajneeshgupta mentioned this pull request Jan 23, 2019
Merged
4 tasks
@amol2jcommerce amol2jcommerce mentioned this pull request Jan 23, 2019
Merged
4 tasks
@ronak2ram ronak2ram mentioned this pull request Feb 17, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Award: bug fix Community Insider: Cedcommerce community-insider-contribution Component: Sales Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@milindsingh @magento-engcom-team @sivaschenko