Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#15950: [Forwardport] Magento2 CSV product import qty and is_in_stock not working correct. #20180

Merged
merged 2 commits into from
Jan 27, 2019

Conversation

p-bystritsky
Copy link
Contributor

@p-bystritsky p-bystritsky commented Jan 10, 2019

Forwardport for #20177

Description

Fixed Issues (if relevant)

  1. Magento2 CSV product import qty and is_in_stock not working correct #15950: Magento2 CSV product import qty and is_in_stock not working correct.

Manual testing scenarios

  1. Create an CSV file for import products
  2. Set Quantity (field qty) to f.E. 99 and is_in_stock to 0 (we want to have quantity for product but set out of stock)
  3. Import CSV

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@p-bystritsky p-bystritsky changed the title magento/magento2#15775: [Forwardport] Incorrect return type getList() in CustomerRepository. magento/magento2#15950: [Forwardport] Magento2 CSV product import qty and is_in_stock not working correct. Jan 10, 2019
@VladimirZaets VladimirZaets self-assigned this Jan 10, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3823 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 27, 2019

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 5477aeb into magento:2.3-develop Jan 27, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants