Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue fixed #20367 In Compare Products page showing horizontal scroll… #20368

Merged
merged 2 commits into from
Jan 29, 2019
Merged

issue fixed #20367 In Compare Products page showing horizontal scroll… #20368

merged 2 commits into from
Jan 29, 2019

Conversation

cedarvinda
Copy link
Member

…bar In body But It should appear in table-wrapper comparison div For mobile device

issue fixed #20367 In Compare Products page showing horizontal scrollbar In body But It should appear in table-wrapper comparison div For mobile device

Manual testing scenarios (*)

Step 1: Open frontend
Step 2: Add two any product to Compare and open Compare Products page in mobile
Step 3: Here will be horizontal scroll in body (Ref screenshot)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…bar In body But It should appear in **table-wrapper comparison** div For mobile device

issue fixed #20367 In Compare Products page showing horizontal scrollbar In body But It should appear in **table-wrapper comparison** div For mobile device
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jan 17, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3899 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment