Order shipping method bug

[mahesh-rajawat]

Fixed: Get Shipping Method as object from order instance gives undefined index.

Description (*)

Get Shipping Method as object from order instance gives undefined index.

Fixed Issues (if relevant)

1. Get Shipping Method as object from order instance gives undefined index. #20380
2. ...

Manual testing scenarios (*)

1. Create a downloadable or virtual product.
2. Place an order with this product.
3. In custom controller or anywhere load order with id.
   $order = $this->orderFactory->create()->load($orderId); //your order id
4. Now get shipping method as object.
   $order->getShippingMethod(true)->getMethod();
   It returns Null now.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3910 has been created to process this Pull Request

[ghost]

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.