Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-Product-page-tabbing-content-misalignment-in-mobile-view :: Pro… #20469

Conversation

parag2jcommerce
Copy link

…duct Page tabbing Content Misaligned in mobile view

Description (*)

Fixed Issues (if relevant)

  1. On Product Page Tabings Content Misaligned on Mobile View #20468: On Product Page Tabings Content Misaligned on Mobile View
  2. ...

Manual testing scenarios (*)

  1. Any product page
  2. Issue find in mobile view (below 768 resolution)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…duct Page tabbing Content Misaligned in mobile view
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 22, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @parag2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20469.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa sdzhepa self-assigned this Jan 29, 2019
@sdzhepa sdzhepa self-requested a review January 29, 2019 14:32
@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-4031 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 1, 2019

Hi @parag2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants