Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popup_content.phtml #20561

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Update popup_content.phtml #20561

merged 1 commit into from
Jan 29, 2019

Conversation

magicsunday
Copy link
Contributor

Description (*)

Avoid duplicate call to getContainers. The method getContainers was previously called twice in template, creating unnecessary overhead (reducing db requests, etc).

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

Create shipment label in packaging popup.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Avoid duplicate call to `getContainers`.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 24, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @magicsunday. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3959 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@magicsunday thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @magicsunday, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit fac8238 into magento:2.3-develop Jan 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @magicsunday. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @magicsunday. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants