Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Issue#20277 fixed for 2.3.x #20748

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 29, 2019

Original Pull Request

#20277

Fixed: Downloading a file from an order where the file type custom option is no longer present results in a 404.

Description (*)

Fixed Issues (if relevant)

  1. Issue#20277 fixed for 2.3.x #20354
  2. ...

Manual testing scenarios (*)

  1. Create a product with a custom option of the type "File"
  2. Create a new order and upload a file for the product as a custom option
  3. Check the order and download the file, this is working.
  4. Update the product and delete the custom option from the product.
  5. Go back to the order and try to download the file again. No longer 404.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review.

@rogyar
Copy link
Contributor

rogyar commented Feb 5, 2019

Hi @amol2jcommerce. Thank you for your contribution. Action interfaces were added in 2.3 version so we cannot use them for 2.2. Also, check the failing tests, please. Thank you

@sidolov
Copy link
Contributor

sidolov commented Feb 19, 2019

@amol2jcommerce , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants