Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entered data missing when entering the wrong date for from, to in cart rule #20895

Merged
merged 8 commits into from
Feb 14, 2019
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

use Magento\Framework\App\Action\HttpPostActionInterface;
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
use Magento\Framework\App\Request\DataPersistorInterface;

/**
* SalesRule save controller
Expand All @@ -20,25 +21,35 @@ class Save extends \Magento\SalesRule\Controller\Adminhtml\Promo\Quote implement
* @var TimezoneInterface
*/
private $timezone;

/**
* @var DataPersistorInterface
*/
private $dataPersistor;

/**
* @param \Magento\Backend\App\Action\Context $context
* @param \Magento\Framework\Registry $coreRegistry
* @param \Magento\Framework\App\Response\Http\FileFactory $fileFactory
* @param \Magento\Framework\Stdlib\DateTime\Filter\Date $dateFilter
* @param TimezoneInterface $timezone
* @param DataPersistorInterface $dataPersistor
*/
public function __construct(
\Magento\Backend\App\Action\Context $context,
\Magento\Framework\Registry $coreRegistry,
\Magento\Framework\App\Response\Http\FileFactory $fileFactory,
\Magento\Framework\Stdlib\DateTime\Filter\Date $dateFilter,
TimezoneInterface $timezone = null
TimezoneInterface $timezone = null,
DataPersistorInterface $dataPersistor = null
) {
parent::__construct($context, $coreRegistry, $fileFactory, $dateFilter);
$this->timezone = $timezone ?? \Magento\Framework\App\ObjectManager::getInstance()->get(
TimezoneInterface::class
);
$this->dataPersistor = $dataPersistor ?? \Magento\Framework\App\ObjectManager::getInstance()->get(
DataPersistorInterface::class
);
}

/**
Expand Down Expand Up @@ -89,6 +100,7 @@ public function execute()
$this->messageManager->addErrorMessage($errorMessage);
}
$session->setPageData($data);
$this->dataPersistor->set('sale_rule', $data);
$this->_redirect('sales_rule/*/edit', ['id' => $model->getId()]);
return;
}
Expand Down
18 changes: 18 additions & 0 deletions app/code/Magento/SalesRule/Model/Rule/DataProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Magento\SalesRule\Model\ResourceModel\Rule\Collection;
use Magento\SalesRule\Model\ResourceModel\Rule\CollectionFactory;
use Magento\SalesRule\Model\Rule;
use Magento\Framework\App\Request\DataPersistorInterface;

/**
* Class DataProvider
Expand Down Expand Up @@ -35,6 +36,11 @@ class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
* @var \Magento\SalesRule\Model\Rule\Metadata\ValueProvider
*/
protected $metadataValueProvider;

/**
* @var DataPersistorInterface
*/
private $dataPersistor;

/**
* Initialize dependencies.
Expand All @@ -45,6 +51,7 @@ class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
* @param CollectionFactory $collectionFactory
* @param \Magento\Framework\Registry $registry
* @param Metadata\ValueProvider $metadataValueProvider
* @param DataPersistorInterface $dataPersistor
* @param array $meta
* @param array $data
*/
Expand All @@ -55,13 +62,17 @@ public function __construct(
CollectionFactory $collectionFactory,
\Magento\Framework\Registry $registry,
\Magento\SalesRule\Model\Rule\Metadata\ValueProvider $metadataValueProvider,
DataPersistorInterface $dataPersistor = null,
array $meta = [],
array $data = []
) {
$this->collection = $collectionFactory->create();
$this->coreRegistry = $registry;
$this->metadataValueProvider = $metadataValueProvider;
$meta = array_replace_recursive($this->getMetadataValues(), $meta);
$this->dataPersistor = $dataPersistor ?? \Magento\Framework\App\ObjectManager::getInstance()->get(
DataPersistorInterface::class
);
parent::__construct($name, $primaryFieldName, $requestFieldName, $meta, $data);
}

Expand Down Expand Up @@ -93,6 +104,13 @@ public function getData()

$this->loadedData[$rule->getId()] = $rule->getData();
}
$data = $this->dataPersistor->get('sale_rule');
if (!empty($data)) {
$rule = $this->collection->getNewEmptyItem();
$rule->setData($data);
$this->loadedData[$rule->getId()] = $rule->getData();
$this->dataPersistor->clear('sale_rule');
}

return $this->loadedData;
}
Expand Down