Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve typo errors for js record.js #20929

Merged
merged 1 commit into from
Feb 4, 2019
Merged

resolve typo errors for js record.js #20929

merged 1 commit into from
Feb 4, 2019

Conversation

neeta-wagento
Copy link
Contributor

Description (*)

Resolve issue for setColumnVisibileListener to setColumnVisibleListener typo on record.js

Manual testing scenarios (*)

  1. Open Magento/backend/en_US/Magento_Ui/js/dynamic-rows/record.js
  2. Check setColumnVisibileListener function
  3. Changed to setColumnVisibileListenerto setColumnVisibleListener

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @neeta-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4097 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7706f15 into magento:2.2-develop Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

Hi @neeta-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Cleanup Component: Ui Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants