Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18698 Fixed order email sending via order async email sending when order was created with disabled email sending #20953

Conversation

serhiyzhovnir
Copy link

@serhiyzhovnir serhiyzhovnir commented Feb 3, 2019

Description (*)

Fixed order email sending via order async email sending when order was created with disabled email sending

Preconditions (*)

  • Magento 2.3.*
  • Magento 2.2.*
  • CRON should be enabled
  • the sales_email/general/async_sending config should be enabled (Stores->Configuration->Sales->Sales Emails->General Settings->Asynchronous sending)

Fixed Issues (if relevant)

  1. Magento triggers and sends some of order emails exactly one month later,while the order email was not enabled then #18698: Magento triggers and sends some of order emails exactly one month later,while the order email was not enabled then

Manual testing scenarios (*)

  1. disable order emails from Stores->configuration->sales emails to not send any email on any new order
  2. after some time , enable the order emails from Stores->configuration->sales emails to send email on new orders
  3. after CRON running the sales_send_order_emails cronjob, you will receive an email of the order creation (the bin/magento cron:run command can be used to trigger the CRON)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… when order was created with disabled email sending
@serhiyzhovnir serhiyzhovnir self-assigned this Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 3, 2019
@serhiyzhovnir serhiyzhovnir changed the title #18698 Fixed order email sending via order async email sending when o… #18698 Fixed order email sending via order async email sending when order was created with disabled email sending Feb 3, 2019
@larsroettig larsroettig self-requested a review February 3, 2019 20:17
@larsroettig larsroettig self-assigned this Feb 3, 2019
@larsroettig
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, here is your new Magento instance.
Admin access: https://pr-20953.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@larsroettig
Copy link
Member

larsroettig commented Feb 3, 2019

✅ Code Review
✅ Manual testing scenarios

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-4101 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 14, 2019
…ending when order was created with disabled email sending #20953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants