Minicart-search-logo-not-vertically-aligned

[amol2jcommerce]

Description (*)

Fixed Issues (if relevant)

1. Minicart, search & logo not vertically aligned between 640 to767 device pixel. #20905: Minicart, search & logo not vertically aligned between 640 to767 device pixel.

Manual testing scenarios (*)

1..Go to frontend -> resize screen (min width 640 and max width 767)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[cedarvinda]

@magento-engcom-team give me test instance.

[magento-engcom-team]

Hi @cedarvinda. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @cedarvinda, here is your new Magento instance.
Admin access: https://pr-20955.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @torhoehn, thank you for the review.
ENGCOM-4118 has been created to process this Pull Request

[Karlasa]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-20955.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Karlasa]

@amol2jcommerce @torhoehn
I don't agree with these changes.
Code should follow coding standards and each component change should be placed into correct module design file.
For correct fix there are really no need for extra lines of code, just breakpoint for design should be changed from @screen__s to @screen__m
example in:

magento2/app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less

Line 425 in ba66e00

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {

magento2/app/design/frontend/Magento/luma/Magento_CatalogSearch/web/css/source/_module.less

Line 202 in ba66e00

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {

and

magento2/app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_minicart.less

Line 414 in ba66e00

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {

[torhoehn]

@Karlasa Ah, you're right.

[amol2jcommerce]

Hi @Karlasa @torhoehn changes updated as per requested.

[magento-engcom-team]

Hi @Karlasa, thank you for the review.
ENGCOM-4118 has been created to process this Pull Request

[magento-engcom-team]

Hi @torhoehn, thank you for the review.
ENGCOM-4118 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[sivaschenko]

Hi @amol2jcommerce the commits in this pull request are not linked to your github account. Can you please check the email configured for github and push the changes as a single commit correctly linked to the author.

[amol2jcommerce]

Hi @sivaschenko, I closed this PR due to committed from different account and that account didn't sign CLA. We generate New PR #21638 for this & sign CLA account.

[ghost]

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.