Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable add to cart until page load #21007

Conversation

sunilit42
Copy link
Contributor

Description (*)

Open a configurable product having DropDown options
When the page is being loaded, you will notice that the dropdowns has no values
Click Add To Cart button during this time. The page will be reloaded and a notice message "Open a configurable product having DropDown options" will be shown

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 6, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @sunilit42 , please, sign CLA, otherwise, we can't process your pull request

1 similar comment
@VladimirZaets
Copy link
Contributor

Hi @sunilit42 , please, sign CLA, otherwise, we can't process your pull request

@sunilit42 sunilit42 force-pushed the disable-addtocart-until-page-load branch from 8ec967d to c09acd8 Compare February 7, 2019 06:20
@sunilit42
Copy link
Contributor Author

@VladimirZaets i did it

@sunilit42
Copy link
Contributor Author

Hi @sunilit42 , please, sign CLA, otherwise, we can't process your pull request

i did it, let me know any thing missing

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4178 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit cffe346 into magento:2.3-develop Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@csdougliss
Copy link
Contributor

Just what I wanted, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants