Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing php doc params to ConvertSerializedDataToJson class constructor #21033

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Add missing php doc params to ConvertSerializedDataToJson class constructor #21033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81571df
magento/magento2.3-develop: Removing unnecessary php doc param from U…
maddumarala Feb 6, 2019
4f62a63
Add missing PHPDoc params to ConvertSerializedDataToJson class constr…
maddumarala Feb 7, 2019
64f053d
More clean up in Ui and Quote components
maddumarala Feb 7, 2019
20faef7
Fix static test.
nmalevanec Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,15 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\Quote\Setup\Patch\Data;

use Magento\Framework\App\ResourceConnection;
use Magento\Quote\Setup\ConvertSerializedDataToJsonFactory;
use Magento\Quote\Setup\QuoteSetupFactory;
use Magento\Framework\Setup\Patch\DataPatchInterface;
use Magento\Framework\Setup\Patch\PatchVersionInterface;

/**
* Class ConvertSerializedDataToJson
* @package Magento\Quote\Setup\Patch
* Convert quote serialized data to json.
*/
class ConvertSerializedDataToJson implements DataPatchInterface, PatchVersionInterface
{
Expand All @@ -36,6 +33,8 @@ class ConvertSerializedDataToJson implements DataPatchInterface, PatchVersionInt
/**
* PatchInitial constructor.
* @param \Magento\Framework\Setup\ModuleDataSetupInterface $moduleDataSetup
* @param QuoteSetupFactory $quoteSetupFactory
* @param ConvertSerializedDataToJsonFactory $convertSerializedDataToJsonFactory
*/
public function __construct(
\Magento\Framework\Setup\ModuleDataSetupInterface $moduleDataSetup,
Expand All @@ -48,7 +47,7 @@ public function __construct(
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function apply()
{
Expand All @@ -57,7 +56,7 @@ public function apply()
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public static function getDependencies()
{
Expand All @@ -67,15 +66,15 @@ public static function getDependencies()
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public static function getVersion()
{
return '2.0.6';
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function getAliases()
{
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Ui/Model/UiComponentGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class UiComponentGenerator
* UiComponentGenerator constructor.
* @param ContextFactory $contextFactory
* @param UiComponentFactory $uiComponentFactory
* @param array $data
*/
public function __construct(
ContextFactory $contextFactory,
Expand All @@ -48,6 +47,7 @@ public function __construct(
* @param string $name
* @param \Magento\Framework\View\LayoutInterface $layout
* @return UiComponentInterface
* @throws \Magento\Framework\Exception\LocalizedException
*/
public function generateUiComponent($name, \Magento\Framework\View\LayoutInterface $layout)
{
Expand Down