Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Pending Reviews' menu item and corrected ACL label #21042

Conversation

rav-redchamps
Copy link
Contributor

Description (*)

  1. Added missing menu item "Pending Reviews" under the admin menu path Marketing > User Content
  2. There were duplicate ACL items with text 'Reviews' under System > User Roles > Add New Role > Role Resources. So renamed one to 'All Reviews' and another one to "Pending Reviews"

Fixed Issues (if relevant)

  1. Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources #20924: Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources

Manual testing scenarios (*)

  1. Verified grid content at the new menu item Marketing > User Content > Pending Reviews
  2. Verified ACL access by creating a new admin user with and without the access of 'Pending Reviews' section

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rav-redchamps
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your Magento instance.
Admin access: https://i-21042-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rav-redchamps
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your new Magento instance.
Admin access: https://pr-21042.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dankhrapiyush
Copy link
Contributor

Hello @rav-redchamps , Thanks for working on this issue but it already fixed under PR #20936

Thank you.

@ghost
Copy link

ghost commented Feb 8, 2019

Hi @rav-redchamps, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@rav-redchamps
Copy link
Contributor Author

Hi @dankhrapiyush

I just checked the PR #20936

I think it will be better if we change the label "Reviews" to "All Reviews". My PR might have other changes as well. Please incorporate the useful changes in yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants