Allow redis compression options to be specified during setup:install process

[cmacdonald-au]

Description (*)

When installing magento, "some" redis cache specific options can be specified. The defaults are usually okay, but in some scenarios they need to be changed.

This PR provides the ability to set the compress_data and compression_lib options consistently for default/backend/redis and page_cache/redis.

Providing these options is preferred over hand-rolled app/etc/env.php "fiddling" when executing a repeatable installation test for the purpose of environment validation.

Fixed Issues (if relevant)

1. n/a

Manual testing scenarios (*)

1. --cache-backend=redis --cache-backend-redis-server=127.0.0.1 --cache-backend-redis-port=6379 --cache-backend-redis-db=3 --page-cache=redis --page-cache-redis-server=127.0.0.1 --page-cache-redis-port=6379 --page-cache-redis-db=4 --cache-backend-redis-compression-lib=lzf --cache-backend-redis-compress-data=1
2. results in the appropriate change in app/etc/env.php

...
    'cache' => [
        'frontend' => [
            'default' => [
                'id_prefix' => '74c_',
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '127.0.0.1',
                    'database' => '3',
                    'port' => '6379',
                    'password' => '',
                    'compress_data' => '1',
                    'compression_lib' => 'lzf'
                ]
            ],
            'page_cache' => [
                'id_prefix' => '74c_',
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '127.0.0.1',
                    'database' => '4',
                    'port' => '6379',
                    'compress_data' => '1',
                    'password' => '',
                    'compression_lib' => ''
                ]
            ]
        ]
    ]

3. installation process should complete and site should function as expected.
4. Cm_Cache_Backend_Redis will throw an exception if an invalid compression_lib (eg: notavalidlib) is supplied and compress_data is enabled.

./bin/magento setup:install --cache-backend=redis --cache-backend-redis-compression-lib=notavalidlib --cache-backend-redis-compress-data=1
Starting Magento installation:
...
...
Running schema recurring...
In Redis.php line 1186:

  Unrecognized 'compression_lib'.

5. Any value can be set as the compression_lib if compress_data is disabled (compression will not be attempted).

./bin/magento setup:install --cache-backend=redis --cache-backend-redis-compression-lib=notavalidlib --cache-backend-redis-compress-data=0
Starting Magento installation:
...
...
[SUCCESS]: Magento installation complete.
...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @cmacdonald-au. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-4267 has been created to process this Pull Request

[magento-engcom-team]

@cmacdonald-au thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @cmacdonald-au, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.