Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Extra space from left in top message section (Notification section) #21161

Merged

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#20962
Extra space from left in top message section (Notification section)

Description (*)

Extra space from left in top message section (Notification section)

Manual testing scenarios (*)

  1. Open admin panel and login
  2. wait in dashboard notification will show tin top of the page (ref screenshot)

Expected result (*)

sol

Actual result (*)

issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Extra space from left in top message section (Notification section)
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor

Karlasa commented Feb 12, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@Karlasa Karlasa self-assigned this Feb 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21161.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4228 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 46f3169 into magento:2.2-develop Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-20962 branch March 26, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants