Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fixed product advanced pricing design issue #21229

Merged
merged 1 commit into from
Feb 19, 2019
Merged

[Backport] Fixed product advanced pricing design issue #21229

merged 1 commit into from
Feb 19, 2019

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Feb 14, 2019 •
edited by sidolov
Loading

Description (*)

Fixed product advanced pricing design issue
Admin >> Add new product >> Advance pricing >> In customer group price all fields alignment not proper.

Fixed Issues (if relevant)

  1. Product Advanced Pricing design issue #18775: Product Advanced Pricing design issue

Manual testing scenarios (*)

  1. Go to Admin
  2. Add new product
  3. Advance pricing
  4. See the Customer Group Price fields
  5. Customer Group Price > Add new options

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18790

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mage2pratik
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik, here is your Magento instance.
Admin access: https://i-21229-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@mage2pratik mage2pratik added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Feb 14, 2019
sidolov
sidolov requested changes Feb 14, 2019
View reviewed changes
app/design/adminhtml/Magento/backend/web/css/source/forms/_fields.less
@@ -527,7 +527,6 @@

& > .admin__field-label {
#mix-grid .column(@field-label-grid__column, @field-grid__columns);
background: @color-white;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change the background color of all admin form fields to fix only one specific issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background color is not require there and "background: @Color-White;" is deleted in 2.3.x. link

@sidolov sidolov added Progress: needs update and removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Feb 14, 2019
@sidolov sidolov self-assigned this Feb 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4311 has been created to process this Pull Request

@sidolov sidolov changed the title Fixed product advanced pricing design issue [Backport] Fixed product advanced pricing design issue Feb 19, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 19, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 079d5d5 into magento:2.2-develop Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 19, 2019
@sidolov
ENGCOM-4311: Fixed product advanced pricing design issue #21229
aa0d326
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 19, 2019
@mage2pratik mage2pratik deleted the patch-8 branch March 26, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Area: Design/Frontend Area: Frontend Component: Ui Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@mage2pratik @magento-engcom-team @sidolov