Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Special price date from issue resolve #21273

Merged

Conversation

tufahu
Copy link
Contributor

@tufahu tufahu commented Feb 15, 2019

Original Pull Request

#18578
Fixed issue of 2.2.6 "Special price date from" Failed to parse time string

Description (*)

In magento 2.2.6 when Account locale set to it_IT and admin user create one new product and set it's special price then it will gives error while saving the product that failed to parse time string. In this Pull Request I have fixed this issue. By modifing date format before it's parse to Date object.

Fixed Issues (if relevant)

  1. 2.2.6 "Special price date from" Failed to parse time string #18158: 2.2.6 "Special price date from" Failed to parse time string

Steps to reproduce

  1. Magento 2.2.6 create a new product with a price
  2. Edit the new product and add a special price

Expected result

  1. The product has been saved

Actual result

  1. DateTime::__construct(): Failed to parse time string (20/09/2018) at position 0 (2): Unexpected character

Manual testing scenarios (*)

  1. Account locale set to it_IT if it's not set.
  2. Add one new product and save. Than edit the product by adding special price and set from date as well. Press Save.
  3. Product Save successfully that message will appear.
  4. Now, Set another account locale and repeat the proceess, product will save successfully again.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tufahu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Feb 15, 2019

Hi @tufahu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tufahu tufahu restored the 2.2-develop-PR-port-18578 branch February 15, 2019 14:45
@tufahu tufahu reopened this Feb 15, 2019
@VladimirZaets VladimirZaets self-assigned this Feb 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4290 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-21273.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @tufahu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants