Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: #21278, Add sort order on downloadable links #21279

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Fixed: #21278, Add sort order on downloadable links #21279

merged 4 commits into from
Mar 8, 2019

Conversation

mahesh-rajawat
Copy link
Member

Fixed: Sort order missing on Downloadable Product Links and Sample Columns.

Description (*)

In this PR, sortOrder issue fixed for Downloadable Product Links and Sample Columns

Fixed Issues (if relevant)

  1. Sort order missing on Downloadable Product Links and Sample Columns #21278
  2. ...

Manual testing scenarios (*)

  1. Followed all steps as mentioned in Sort order missing on Downloadable Product Links and Sample Columns #21278 issue.
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat mahesh-rajawat force-pushed the add-sort-order-downloadable-links branch from 9b0bb55 to c9a9d64 Compare February 15, 2019 18:55
sivaschenko
sivaschenko requested changes Feb 19, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maheshWebkul721 thanks for the pull request!

Adding parameters to protected methods is not backward compatible approach.

Considering the general approach to data in this file and taking into account that this PR is hardcoding sort orders in the file anyway, I think it's alright to stick to existing approach forr setting sort order:

magento2/app/code/Magento/Downloadable/Ui/DataProvider/Product/Form/Modifier/Links.php

Line 116 in 9cdc1b7

'sortOrder' => 30,
- specifying exact sort order directly in the array.

@sivaschenko sivaschenko self-assigned this Feb 19, 2019
@mahesh-rajawat
Copy link
Member Author

@sivaschenko , i have fixed it.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4345 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 4, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 4, 2019
@nmalevanec
Fix static tests.
03f0c3a
@nmalevanec
Merge remote-tracking branch 'mainline/2.3-develop' into add-sort-ord…
81a4de8 
…er-downloadable-links

# Conflicts:
#	app/code/Magento/Downloadable/Ui/DataProvider/Product/Form/Modifier/Links.php
#	app/code/Magento/Downloadable/Ui/DataProvider/Product/Form/Modifier/Samples.php
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 8, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 81a4de8 into magento:2.3-develop Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 8, 2019
@sidolov
ENGCOM-4345: Fixed: #21278, Add sort order on downloadable links #21279
c9ca454
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 8, 2019
@mage2pratik mage2pratik mentioned this pull request Mar 8, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: Downloadable Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@mahesh-rajawat @magento-engcom-team @VasylShvorak @sivaschenko @sidolov @nmalevanec