Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Applied PHP-CS-Fixer: concat_space, no_multiline_whitespace_around_double_arrow, ordered_imports #21313

Conversation

priti2jcommerce
Copy link
Contributor

Original Pull Request

#21121

Description (*)

Applied following fixer rules:

  • PHP CS Fixer: concat_space
  • PHP CS Fixer: no_multiline_whitespace_around_double_arrow
  • PHP CS Fixer: ordered_imports

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: GroupedProduct Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Release Line: 2.2 Partner: Two Jay partners-contribution Pull Request is created by Magento Partner labels Feb 19, 2019
@dmytro-ch
Copy link
Contributor

Unfortunately, we can't accept this Pull Request to 2.2 release line, all code cleanup should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide.
Thank you!

@dmytro-ch dmytro-ch closed this Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dmytro-ch dmytro-ch self-assigned this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GroupedProduct Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants