[Backport] Fix issue 21177 - Cart page cross-sell product add-to-cart button issue resolved

[speedy008]

Original Pull Request

#21178

Description (*)

Cart page cross-sell product add-to-cart button issue resolved
Magento 2.3-develop

Fixed Issues (if relevant)

1.#21177: Cart Page cross sell product Add to cart button overlapping

Manual testing scenarios (*)

1.Add any product to cart into frontend(Note : This product must have cross-sell product added from backend )
2.Check Cross-sell product into 640 * 767 screen.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4322 has been created to process this Pull Request

[sivaschenko]

Hi @speedy008 , thanks for the backport!

However, the original pull request is marked as a cleanup. We cannot accept cleanup pull requests to 2.2-develop.

See Contribution Guide for details.

[ghost]

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[Ctucker9233]

@sivaschenko Can you explain this logic of not accepting Backported cleanup pull requests? From what I read in the contributor guide, any kind of cleanup must be done in 2.3 first, but it does not clearly indicate that it cannot be backported. If 2.2 officially at end of life then?

[sivaschenko]

@Ctucker9233 please see the table here As you can see from the table cleanups and new features are welcome to the latest version of Magento. More critical contributions like bugfixes, refactorings and test coverage are backported to 2.2

[Ctucker9233]

@sivaschenko I see. Thanks for the clarification. This particular PR looks like it fixes a styling issue with a button. I'm just trying to understand why it is considered clean-up and not an improvement. I would think that any code that improves the frontend experience would be great to backport.

[sivaschenko]

@Ctucker9233 actually every pull request to the repository is an improvement to the framework, however, according to the current convention, minor style improvements are considered as cleanups.