[Backport]-issue-195196 Customer related values are NULL for guests converted to customers after checkout.

[Nazar65]

Original PR #19191

Description (*)

Customer name and all customer related values should not be NULL

Fixed Issues (if relevant)

1. Customer related values are NULL for guests converted to customers after checkout. #19166:Customer related values are NULL for guests converted to customers after checkout.

Manual testing scenarios (*)

1. Allow customers to create account after checkout
2. Create few orders as guest customers and create an account after checkout process
3. Create a module with a plugin aroundSave for SalesOrder class
4. In aroundSave method, try to fetch customer name from order object

public function aroundSave(
        OrderResource $subject,
        \Closure $proceed,
        SalesOrder $order
    ) {
        [...]
        if ($order->getCustomerId()) {
            $customerName = $order->getCustomerName(); // returns Customer Name
        [...]
        }
    }

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Nazar65]

HI @rogyar any updates ?

[sivaschenko]

hi @Nazar65 thanks for backport, I have a question regarding the implementation, can you please check my code review note

[sivaschenko]

Is this check by design, or did you mean to check $quote->hasCustomerMiddlename here?

[Nazar65]

Yes in original Pr i was check if $quote->hasCustomerMiddlename but now i don't know how i did this, i'm will add a propper check

[Nazar65]

Hi @sivaschenko i've added a valid check for customer middle name, is this check be valid ? or we can add a method as you mentioned hasCustomerMiddlename ?

[sivaschenko]

Thanks @Nazar65 , no need to add new methods

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-4390 has been created to process this Pull Request

[ghost]

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.